Add base addressbook to GUI #102

pitmutt · 2024-08-03T12:20:10Z

pitmutt commented

2024-08-03 12:20:10 +00:00

(Migrated from git.vergara.tech)

No description provided.

pitmutt (Migrated from git.vergara.tech) reviewed 2024-08-03 12:26:13 +00:00

pitmutt (Migrated from git.vergara.tech) left a comment

The docker image needs to be removed from this branch before merging.

src/Zenith/GUI.hs

pitmutt (Migrated from git.vergara.tech) commented

2024-08-03 12:34:33 +00:00

Any new windows should be lower priority than msgOverlay, so the message window displays above. Also, the wallet sync notification uses modalOverlay and needs to be the top widget to make sure that no activities are performed during sync.

Any new windows should be lower priority than `msgOverlay`, so the message window displays above. Also, the wallet sync notification uses `modalOverlay` and needs to be the top widget to make sure that no activities are performed during sync.

src/Zenith/GUI.hs

pitmutt (Migrated from git.vergara.tech) commented

2024-08-03 12:26:13 +00:00

This is unnecessary, the event can be used directly

src/Zenith/GUI.hs

pitmutt (Migrated from git.vergara.tech) commented

2024-08-03 12:32:34 +00:00

Using model & msg ?~ ... uses the msgOverlay dialog box that is lower in the widgetTree priority.

Using `model & msg ?~ ...` uses the `msgOverlay` dialog box that is lower in the `widgetTree` priority.

src/Zenith/GUI.hs

pitmutt (Migrated from git.vergara.tech) commented

2024-08-03 12:35:56 +00:00

Too many parenthesis, use $ instead.

Too many parenthesis, use `$` instead.

src/Zenith/GUI.hs

pitmutt (Migrated from git.vergara.tech) commented

2024-08-03 12:36:16 +00:00

Too many parenthesis, use $ instead.

Too many parenthesis, use `$` instead.

src/Zenith/Utils.hs

pitmutt (Migrated from git.vergara.tech) commented

2024-08-03 12:37:44 +00:00

This line is redundant, use homeDirectory <- getHomeDirectory directly.

This line is redundant, use `homeDirectory <- getHomeDirectory` directly.

pitmutt (Migrated from git.vergara.tech) reviewed 2024-09-03 18:45:00 +00:00

src/Zenith/GUI.hs

					
				@ -1658,62 +1438,32 @@ handleEvent wenv node model evt =

				    -- | Address Book -> save new entry into database

pitmutt (Migrated from git.vergara.tech) commented

2024-09-03 18:45:00 +00:00

@reneve Your new fields in the state should be after the hD variable, not before

@reneve Your new fields in the state should be after the `hD` variable, not before

pitmutt referenced this pull request from a commit

2025-01-14 19:53:27 +00:00

Merge pull request 'Add base addressbook to GUI' (#102) from rvv041 into milestone3

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Vergara_Tech/zenith#102

				`@ -1658,62 +1438,32 @@ handleEvent wenv node model evt =`
				`-- \| Address Book -> save new entry into database`