Vergara_Tech/zenith
2
0
Fork 0
Code Issues 24 Pull requests Projects Releases 9 Packages Wiki Activity Actions

rvv041 #82

Merged
reneve merged 0 commits from refs/pull/82/head into milestone2 2024-06-07 20:03:06 +00:00
Conversation 0 Commits - Files changed -
reneve commented 2024-05-13 00:52:03 +00:00 (Migrated from git.vergara.tech)
Copy link

Address book table added to DB.hs
getAdrBook function to retrieve a list of addresses created.

Address book table added to DB.hs getAdrBook function to retrieve a list of addresses created.
pitmutt (Migrated from git.vergara.tech) approved these changes 2024-06-03 14:15:03 +00:00
pitmutt (Migrated from git.vergara.tech) reviewed 2024-06-03 14:28:06 +00:00
CHANGELOG.md
@ -52,4 +10,1 @@
- Address Book functionality. Allows users to store frequently used zcash addresses and
generate transactions using them.
### Changed
pitmutt (Migrated from git.vergara.tech) commented 2024-06-03 14:51:14 +00:00
Copy link

These changes should be added as a new version [0.5.3.0-beta]

These changes should be added as a new version `[0.5.3.0-beta]`
src/Zenith/CLI.hs
@ -3,6 +3,7 @@
{-# LANGUAGE OverloadedStrings #-}
{-# LANGUAGE ScopedTypeVariables #-}
pitmutt (Migrated from git.vergara.tech) commented 2024-06-03 14:30:17 +00:00
Copy link

This option is not required.

This option is not required.
src/Zenith/CLI.hs
pitmutt (Migrated from git.vergara.tech) commented 2024-06-03 14:31:55 +00:00
Copy link

The name of the field should be _abDescrip so the there are no conflict with the lens.

The name of the field should be `_abDescrip` so the there are no conflict with the lens.
pitmutt (Migrated from git.vergara.tech) commented 2024-06-03 19:11:35 +00:00
Copy link

@reneve It's better to use more specific name fields to avoid conflicts.

@reneve It's better to use more specific name fields to avoid conflicts.
src/Zenith/CLI.hs
pitmutt (Migrated from git.vergara.tech) commented 2024-06-03 14:32:43 +00:00
Copy link

The name of the field should be _abAddress so no conflicts with existing fields are found.

The name of the field should be `_abAddress` so no conflicts with existing fields are found.
src/Zenith/CLI.hs
pitmutt (Migrated from git.vergara.tech) commented 2024-06-03 14:42:58 +00:00
Copy link

The field should be named _abAddresses

The field should be named `_abAddresses`
src/Zenith/CLI.hs
@ -203,9 +197,8 @@ data State = State
, _txForm :: !(Form SendInput () Name)
pitmutt (Migrated from git.vergara.tech) commented 2024-06-03 14:46:40 +00:00
Copy link

What is this field for?

What is this field for?
src/Zenith/CLI.hs
@ -203,9 +197,8 @@ data State = State
, _txForm :: !(Form SendInput () Name)
, _abAddresses :: !(L.List Name (Entity AddressBook))
pitmutt (Migrated from git.vergara.tech) commented 2024-06-03 14:46:50 +00:00
Copy link

What is this field for?

What is this field for?
src/Zenith/CLI.hs
@ -1382,3 +1322,4 @@
then zcashWalletLastSync $ entityVal $ head walList
else 0
abookList <- getAdrBook pool $ zgb_net chainInfo
pitmutt (Migrated from git.vergara.tech) commented 2024-06-03 14:37:58 +00:00
Copy link

The ABList needs to be removed from the focus ring, it is not visible on the main screen.

The `ABList` needs to be removed from the focus ring, it is not visible on the main screen.
src/Zenith/DB.hs
pitmutt (Migrated from git.vergara.tech) commented 2024-06-03 14:30:44 +00:00
Copy link

This option is not required

This option is not required
src/Zenith/DB.hs
pitmutt (Migrated from git.vergara.tech) commented 2024-06-03 14:28:06 +00:00
Copy link

If this function is intended to provide only one record, it should return a IO (Maybe (Entity AddressBook))

If this function is intended to provide only one record, it should return a `IO (Maybe (Entity AddressBook))`
pitmutt (Migrated from git.vergara.tech) reviewed 2024-06-04 12:18:38 +00:00
pitmutt (Migrated from git.vergara.tech) reviewed 2024-06-04 12:21:53 +00:00
pitmutt (Migrated from git.vergara.tech) left a comment
Copy link

Please review the comments on the copy address message.

Please review the comments on the copy address message.
src/Zenith/CLI.hs
pitmutt (Migrated from git.vergara.tech) commented 2024-06-04 12:21:53 +00:00
Copy link

It is not necessary to show the address, it is too long for the message window. We should only use the name in the message.

It is not necessary to show the address, it is too long for the message window. We should only use the name in the message.
Sign in to join this conversation.
Reviewers
No reviewers
pitmutt
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
MVP 2
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Vergara_Tech/zenith#82
No description provided.
Delete branch "refs/pull/82/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?